I do think it’s a very valid point that suicide as a happy ending is a harmful message to send.
But the aspect of her accepting responsibility for her actions was a great redemptive moment.
I just wish they’d had another way to break the curse apart from her death, because if ever there was a villain who had a shot at changing and living out a happy life with their loved ones, Ingrid was it. That would have been a far more satisfying end to her story, going back to Arendelle and being the aunt to the Queen. Guess Disney wouldn’t let them do that though, so instead she had to die. *sigh*